Dave Airlie writes: > > > > I had been hoping for some more comments from the "senior" DRI hackers. > > Egbert's patch takes somewhat the opposite approach from mine; where I > > extended the RADEONDRIRec structure to have space for 64-bit handles, > > Egbert's patch unconditionally makes the drm_handle_t be 32-bit. > > Which is fine if the DRI developers generally agree that limiting > > handles to 32 bits is OK, but I don't think that discussion has been > > had yet. > > Yes a bit of interest from idr, alanh and keithw might help us out here... > (and anyone else who knows this area).... > > > > > server and the DRI client is largely separate from the issue of > > communication between them and the kernel. The one thing that links > > them is the question of whether handles are always limited to 32 bits > > or not. > > Since my area is the DRM and to show why macros were to me not useful I've > just checked mga and r128 ports of Egberts code to your framework into DRM > CVS, I'd really appreciate someone compile testing them at least (my cross > compiler setup is hosed, I'll fix it in the next day or two..), I'd also > appreciate if someone could tell me if idr's new mga ioctls need compat > code or not ...
The key should be to fix them so they don't as long as they are not yet released. Often times it is more a lack of knowledge than necessity that these conversions are needed. > > Now I've hacked that code together in little over two hours (while > watching Raiders of the lost Ark) I don't see the advantage adding all the > macros will bring, once you've identified which structs/ioctls need work, > a quick editor macro can generate the code nearly... (granted I'm sure > there are bugs in what I've just done...) Right. Those bugs have been removed from my code already. Egbert. ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
