http://bugs.freedesktop.org/show_bug.cgi?id=10529





------- Comment #23 from [EMAIL PROTECTED]  2007-04-17 09:09 PST -------
(In reply to comment #21)
> Looks slightly unnatural :-).
> The fog code in this driver looks like it could need some cleanup, it seems to
> have degenerated a bit. There are for instance references like this:
>       /* Hack: make sure fog is correctly enabled according to this
>        * fragment program's fog options.
>        */
> except if you look at the function call it's a no-op nowadays...
> As far as I can tell the whole i915_update_fog function is basically obsolete
> since the appending of the fog in the fragment program. Not sure though, hw 
> fog
> might still get enabled if this is called before the update of the fragment
> program (which would add a bogus fog calc in addition of the correct one
> probably). So, could you try never setting S5_FOG_ENABLE in i915_state.c? You
> can just comment it out.
> 

I commented out the entire if/then/else block containing the S5_FOG_ENABLE (I
assume that's what you wanted), and re-built. The only change in doing this is
that the screen appears slightly brighter. The solid wall is still there
instead of the properly rendered fog.

Did you instead want me to comment out only one of those lines from the block?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to