> > What do you think? > > We try to keep #ifdef's out of the code and in drm_compat.h instead. > Something like > > #if linuxversion >= 2.6.27 > #define drm_on_each_cpu(handler, data, wait) ... > #else > ... > #endif > > and then just user drm_on_each_cpu in the code. >
I'd prefer not to do that at all, it makes upstream merging a lot messier. The ifdefs make life easier as I have a script to remove them :) Dave. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
