Steven Stallion wrote:
> Garrett,
>
> I've finished up a second pass on the dnet GLDv3 conversion. You can
> find the diffs here: http://cr.opensolaris.org/~stallion/dnet/2/
>
> In this round: I've dropped all superfluous mac_register_t references.
> I have also added a couple of missing/previously uninitialized values
> in dnet_attach() for mac_register_t.
>
> Next on the list is:
>
> 1) Add vlan tagging
> 2) Add link notification
>
> So, once the rest of these changes are complete (and tested), what is
> the next step? Any word on Brussels integration?
>
>
> Cheers,
>
> Steve
>
I sure do wish you'd generate a real webrev. The problem with your
diffs is that they lack line numbers, which makes it harder to offer up
review comments.
Anyway, here's some thoughts so far:
1) no need to initialize macp->m_pdata or macp->p_data_size. (In fact,
those fields should probably *not* be touched.)
2) rather than fix the various DNETTRACE cmn_err's, I'd just remove
those blocks --- you're already touching the cmn_err, which isn't
needed, so better to clean it up this time around. (But only the ones
like DNETTRACE that just show function entry or exit points. I've not
checked for other DNETDEBUG cases.)
3) Just a question: can tx_interrupt_mask in the dnet_mc_tx() routine
just be treated as a constant? I'm not sure with the removal of the
GLD_INTR_WAIT code that there is any point to having a separate variable
here. But I need to look at the whole function to verify that.
4) Ditto for the handling in dnet_intr().
The rest of this looks pretty good.
-- Garrett
_______________________________________________
driver-discuss mailing list
driver-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/driver-discuss
