Alan DuBoff wrote: > On Mon, 11 Feb 2008, Garrett D'Amore wrote: > >> I sure do wish you'd generate a real webrev. The problem with your >> diffs is that they lack line numbers, which makes it harder to offer up >> review comments. > > I agree, but most of the people in the community don't know what a > webrev is, so it's usually not that they didn't want to give it to you > that way, they just don't know what the heck it is...:-/ > > I have one machine that only has OpenSolaris and the community tools on > it, I'm booting it to see what they have included in the tools before I > speak un-intelligently. > > Ok, so I see wx and webrev there, and presumably the workspace concept > exists. I would be curious if community folks are using wx, and if not, > maybe we should educate some of them on that, or try to. I'm not sure if > wx is neutered down, or how it would deal with parents and clones, or if > that would matter... > > OTOH, maybe Steven does know what a webrev is but just didn't both and > gave you diffs on his own. I don't know that this is or is not the case, > but just pointing out that many of the community folks really do not > even know what tools are there and what they are used for, and I suspect > webrev is one of them.
Honestly, I'd love to be able to give you guys a webrev - generating/posting diffs from mercurial is a bit on the onerous side. I spent a bit of time trying to get webrev functioning with mercurial with very little luck. Steve Lau offered up a few suggestions, but I still have not been able to get it working correctly. I may (or may not) be out of line by saying this, but working with ON tools and mercurial seems to be a bit of a minefield. > -- > > Alan DuBoff - Solaris x86 IHV/OEM Group -- Yet magic and hierarchy arise from the same source, and this source has a null pointer. Reference the NULL within NULL, it is the gateway to all wizardry. _______________________________________________ driver-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/driver-discuss
