[
https://jira.duraspace.org/browse/DS-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22553#comment-22553
]
Mark Diggory commented on DS-1004:
----------------------------------
To clarify what I dislike about this patch, it has to do with extending the
HandleTypeMatcher to introduce "Wihdrawn" as a type of DSpaceObject when it is
a state of a DSpace Object.
Index: src/main/java/org/dspace/app/xmlui/aspect/general/HandleTypeMatcher.java
===================================================================
--- src/main/java/org/dspace/app/xmlui/aspect/general/HandleTypeMatcher.java
(revision 6579)
+++ src/main/java/org/dspace/app/xmlui/aspect/general/HandleTypeMatcher.java
(working copy)
@@ -17,6 +17,7 @@
import org.apache.cocoon.sitemap.PatternException;
import org.dspace.app.xmlui.utils.HandleUtil;
import org.dspace.content.DSpaceObject;
+import org.dspace.content.Item;
import org.dspace.core.Constants;
/**
@@ -37,10 +38,13 @@
public static final String COMMUNITY_EXPRESSION = "community";
/** The collection expression */
- public static final String COLLECITON_EXPRESSION = "collection";
+ public static final String COLLECTION_EXPRESSION = "collection";
/** The item expression */
public static final String ITEM_EXPRESSION = "item";
+
+ /** The withdrawn item expression */
+ public static final String WITHDRAWN_EXPRESSION = "withdrawn";
/**
* Match the encoded DSpaceObject against a specified type.
@@ -58,8 +62,9 @@
for (String expression : expressions)
{
if (!(COMMUNITY_EXPRESSION.equals(expression)
- || COLLECITON_EXPRESSION.equals(expression) ||
ITEM_EXPRESSION
- .equals(expression)))
+ || COLLECTION_EXPRESSION.equals(expression)
+ || WITHDRAWN_EXPRESSION.equals(expression)
+ || ITEM_EXPRESSION.equals(expression)))
> Add optional reason text to tombstone page (XMLUI)
> --------------------------------------------------
>
> Key: DS-1004
> URL: https://jira.duraspace.org/browse/DS-1004
> Project: DSpace
> Issue Type: Improvement
> Components: XMLUI
> Affects Versions: 1.8.0
> Reporter: Richard Rodgers
> Assignee: Richard Rodgers
> Fix For: 1.8.0
>
> Attachments: tombstone_dspace-xmlui-api.patch,
> tombstone_dspace-xmlui-webapp.patch
>
>
> Companion to DS-587 - that is, a configurable tombstone 'reason'. The primary
> difference is that XMLUI never displayed a tombstone page at all,
> just the (erroneous) RestrictedItem page. This restores the parity between
> JSPUI and XMLUI
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
