Christian Ohler <[EMAIL PROTECTED]> writes: > Committing from the diff buffer has questionable utility since you can > just as easily use the status buffer to commit. And it creates the > problems I described. It's a good candidate for removal.
I'd like to have the feedback of other DVC users and developers, but to me, the "diff/edit-log/commit" cycle *is* the most meaningfull. So, you're indeed proposing to remove what is the most usefull thing to me in DVC. > Or let me phrase that as a question: What IS the major benefit of > being able to mark files and commit from diff buffers? I usually review my changes before committing, and everybody should. The status buffer can be a starting point, but it doesn't show the changes you want to review. So, you need one more buffer. Now, you can have a status buffer, and one diff buffer per file. DVC alredy supports this, it's just `=' in the status buffer. But having all the stuff in a single buffer makes it really more conveinient. When you have many small changes to multiple files, the status + 1 diff-buffer per file quickly becomes painfull. You could have one buffer with the complete diff plus the status buffer. If you manage to resize the buffers to avoid status taking half the screen even if it's to show <5 files, if you have a good synchro between them (equivalent of `j' currently), ... it can be manageable. > Why can't you use a status buffer, perhaps with a diff buffer > visible in a separate window? What other solutions to the problems > of meaningless keybindings and committing from the wrong diff do you > see? Avoiding committing to the wrong diff is relatively trivial, since you have two variables giving you the base revision, you can easily check that the base revision is the HEAD. Even easier, you can just mark the buffer as OK to commit from after creating it, that's one local variable. BTW, commiting from a diff buffer which isn't against the head can be meaningfull too. For example, "git commit --amend" commits against the ancestor of the head, and discards the current head (I don't think we have a good interface for this in DVC). -- Matthieu _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
