Michael Olson <[EMAIL PROTECTED]> writes:

> Stephen Leake <[EMAIL PROTECTED]> writes:
>
>> Michael Olson <[EMAIL PROTECTED]> writes:
>>
>>> I've renamed the default pretty-printer to dvc-fileinfo-printer-full.
>>> While doing so, I changed the rename and copy indicators to use an
>>> arrow for the target, because seeing -source and -target is not
>>> appealing to me.  What do others think?
>>
>> I don't like this part of this change. The source and target of the
>> renames are not always next to each other in the buffer, so the arrow
>> is just confusing. The -source and -target labels are at least
>> unambiguous.
>>
>> Having a choice of pretty-printers is fine otherwise.
>>
>> I don't see a good way to make just the arrow a user option.
>
> What backend does not place them next to each other?  

monotone

The files are listed in alphabetical order. Since the names are
arbitrary, there is no guarantee where they show up.

> That would be extremely confusing, regardless of whether arrows or
> -source/-target were displayed, I would think.

Well, yes. Unless the user remembers doing the rename, or the names
make sense, the only way to figure it out is to read all the possible
pairs of files.

But in general, I find alphabetical order very helpful. And renames
should be rare, and the user should commit immediately after the
renames, so I don't think it's much of a problem.

-- 
-- Stephe

_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev

Reply via email to