Am Di., 18. Sep. 2018 um 17:10 Uhr schrieb Desimone, Nathaniel L < nathaniel.l.desim...@intel.com>:
> The EDK2 coding standard specifies that all files should be in CR-LF > format. Please see the following: > https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/5_source_files/#51-general-rules Thank you for the pointer! Is the .gitattributes file alone sufficient? > The conversion of the file is for the repo-internal representation (which defaults to LF given git's origin on unix-like systems). According to the docs, due to the "text" property it should still checkout with CRLF on CRLF platforms (as long as core.eol is kept at its default "native" value, otherwise core.eol and core.autocrlf will influence that decision). I don't have such a system around, so my ability to test is limited. The problem with having CRLF in the file on unixoids is that it elicits an error like the following when calling it directly: $ IntelFsp2Pkg/Tools/SplitFspBin.py /usr/bin/env: 'python\r': No such file or directory If the autoconversion is not considered good enough, I'd propose keeping out patch 1 of this series that adds the #! line and the executable bit, and instead expect people to always call the script with "python $path/SplitFspBin.py" to keep confusion at a minimum. Regards, Patrick _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
