Good to know. Thanks!
> -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Patrick Georgi > Sent: Wednesday, September 26, 2018 11:59 PM > To: Yao, Jiewen <jiewen....@intel.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 3/3] IntelFsp2Pkg: Tell git to format > SplitFspBin.py > with native newlines > > I'm fine with discarding 1/3 and 3/3. > 2/3 was already merged by Chasel Chui > (commit 9062ab47870ea728307e32cdd939586a4ec67fc6), so from my point > of > view, that patch set is taken care of. > > > Thanks, > Patrick > > Am Mi., 26. Sep. 2018 um 05:13 Uhr schrieb Yao, Jiewen > <jiewen....@intel.com > >: > > > Hi Patrick > > Do you agree that we only need merge 2/3 and discard 1/3 and 3/3? > > > > I will push 2/3 after get your confirmation. > > > > Thank you > > Yao Jiewen > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf > Of > > > Desimone, Nathaniel L > > > Sent: Thursday, September 20, 2018 12:38 PM > > > To: Patrick Georgi <pgeo...@google.com> > > > Cc: edk2-devel@lists.01.org > > > Subject: Re: [edk2] [PATCH 3/3] IntelFsp2Pkg: Tell git to format > > SplitFspBin.py > > > with native newlines > > > > > > Hi Patrick, > > > > > > > If the autoconversion is not considered good enough, I'd propose > > keeping > > > out patch 1 of this series that adds the #! line and the executable bit, > > and > > > instead expect people to always call the script with "python > > > $path/SplitFspBin.py" to keep confusion at a minimum. > > > > > > There was quite a debate on this a few years ago. Without getting into > > the > > > details, the decision was made that people on Windows platforms would > set > > > core.autocrlf=false and that source code would be stored in CR-LF > format. > > > Per your recommendation, it sounds like we should only merge patch 2 > > then. > > > > > > Thanks, > > > Nate > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel > > > > > -- > Google Germany GmbH, ABC-Str. 19, 20354 Hamburg > Registergericht und -nummer: Hamburg, HRB 86891, Sitz der Gesellschaft: > Hamburg > Geschäftsführer: Paul Manicle, Halimah DeLaine Prado > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
