Jordan -- During early bring up, RTC may not be working or have hardware errors. But failure to install this protocol prevents DXE core from booting at all. Perhaps we would like to debug the RTC problems from an environment like the shell. So, allowing the RTC driver to return an error permits more robust bring up.
Tim -----Original Message----- From: Jordan Justen [mailto:[email protected]] Sent: Thursday, May 09, 2013 9:32 AM To: [email protected] Cc: Harry Liebel Subject: Re: [edk2] [PATCH] ShellPkg: Check the error of gRT->GetTime() On Thu, May 9, 2013 at 8:31 AM, Olivier Martin <[email protected]> wrote: > Dear ShellPkg maintainer, > > Please find the attached patch that fixes the ShellPkg when > gRT->GetTime() returns an error (eg: early UEFI platform bringup with > a RTC controller that is not supported). > > On some platforms, gRT->GetTime() might not return EFI_SUCCESS. The > Shell must check the return status before to assume the returned time is > valid. If a platform doesn't support GetTime, then gEfiRealTimeClockArchProtocolGuid won't be installed, right? I don't understand the need for this change, or the FatPkg change. Maybe another possible idea would be a RealTimeClockArch driver that always returns a hard coded time for the case you describe. -Jordan ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
