Actually, we found the issue with the BeagleBoard two years ago. The UEFI BeagleBoard Firmware at this time did not have RTC support in UEFI. As Andrew said, the firmware was using EmbeddedPkg/RealTimeClockRuntimeDxe and its library EmbeddedPkg/Library/TemplateRealTimeClockLib to provide gEfiRealTimeClockArchProtocolGuid to pass the DXE core initialization. But we realized the FAT driver had issues when gRT->GetTime() did not return a valid date time (what TemplateRealTimeClockLib does).
Harry recently was working on a BlockIo device on a new platform and got the same issue again (we did not have this patch in our Fat binary). Because, he was using EFI Shell, he took the opportunity to search on gRT->GetTime() in the code to ensure the return status was checked. ________________________________________ From: Jordan Justen [[email protected]] Sent: 09 May 2013 18:01 To: Andrew Fish; Olivier Martin Cc: [email protected] Subject: Re: [edk2] [PATCH] ShellPkg: Check the error of gRT->GetTime() On Thu, 2013-05-09 at 09:48 -0700, Andrew Fish wrote: > I don't see why we assume that the time is always correct? > What happens if you lose the battery and your driver knows the time > is not valid per the UEFI spec it would return EFI_DEVICE_ERROR? > It seems reasonable for the code calling GetTime() to deal with a > EFI_DEVICE_ERROR return. > > EFI_DEVICE_ERROR > The time could not be retrieved due to a hardware error. Good points. Although, it doesn't seem to have been much of an issue in the past... Olivier, Is FatPkg and ShellPkg the only issues you've found? If not, at this point do you have any idea how extensive this issue is? (How much code needs to be updated.) -Jordan ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
