Thanks Olivier.
-----Original Message----- From: Olivier Martin [mailto:[email protected]] Sent: Tuesday, August 27, 2013 12:06 PM To: [email protected]; Andrew Fish Cc: Harry Liebel Subject: Re: [edk2] [PATCH] ShellPkg: Check the error of gRT->GetTime() The fix has been committed into SVN rev14337 (09/05/2013): "ShellPkg: Update behavior for GetTime() errors" > -----Original Message----- > From: Sivasakthivel Nainar [mailto:[email protected]] > Sent: 27 August 2013 16:58 > To: [email protected]; Andrew Fish > Cc: Harry Liebel > Subject: Re: [edk2] [PATCH] ShellPkg: Check the error of > gRT->GetTime() > > Hi All, > I would like to know the updates on this issue. We also have a > similar problem. One of our hardware does not have RTC. Is there any > resolution made on this? > > Thanks > Siva > > > -----Original Message----- > From: Olivier Martin [mailto:[email protected]] > Sent: Thursday, May 09, 2013 5:33 PM > To: [email protected]; Andrew Fish > Cc: Harry Liebel > Subject: Re: [edk2] [PATCH] ShellPkg: Check the error of > gRT->GetTime() > > Actually, we found the issue with the BeagleBoard two years ago. The > UEFI BeagleBoard Firmware at this time did not have RTC support in > UEFI. > As Andrew said, the firmware was using > EmbeddedPkg/RealTimeClockRuntimeDxe and its library > EmbeddedPkg/Library/TemplateRealTimeClockLib to provide > gEfiRealTimeClockArchProtocolGuid to pass the DXE core initialization. > But we realized the FAT driver had issues when gRT->GetTime() did not > return a valid date time (what TemplateRealTimeClockLib does). > > Harry recently was working on a BlockIo device on a new platform and > got the same issue again (we did not have this patch in our Fat > binary). > Because, he was using EFI Shell, he took the opportunity to search on > gRT->GetTime() in the code to ensure the return status was checked. > > > ________________________________________ > From: Jordan Justen [[email protected]] > Sent: 09 May 2013 18:01 > To: Andrew Fish; Olivier Martin > Cc: [email protected] > Subject: Re: [edk2] [PATCH] ShellPkg: Check the error of > gRT->GetTime() > > On Thu, 2013-05-09 at 09:48 -0700, Andrew Fish wrote: > > I don't see why we assume that the time is always correct? > > What happens if you lose the battery and your driver knows the time > is > > not valid per the UEFI spec it would return EFI_DEVICE_ERROR? > > It seems reasonable for the code calling GetTime() to deal with a > > EFI_DEVICE_ERROR return. > > > > EFI_DEVICE_ERROR > > The time could not be retrieved due to a hardware error. > > Good points. Although, it doesn't seem to have been much of an issue > in the past... > > Olivier, > > Is FatPkg and ShellPkg the only issues you've found? If not, at this > point do you have any idea how extensive this issue is? (How much code > needs to be updated.) > > -Jordan > > > > ---------------------------------------------------------------------- > - > ------- > Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" > is the definitive new guide to graph databases and their applications. > This 200-page book is written by three acclaimed leaders in the field. > The early access version is available now. > Download your free book today! http://p.sf.net/sfu/neotech_d2d_may > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > -- IMPORTANT NOTICE: The contents of this email and any attachments > are confidential and may also be privileged. If you are not the > intended recipient, please notify the sender immediately and do not > disclose the contents to any other person, use it for any purpose, or > store or copy the information in any medium. Thank you. > > > ---------------------------------------------------------------------- > - > ------- > Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" > is the definitive new guide to graph databases and their applications. > This 200-page book is written by three acclaimed leaders in the field. > The early access version is available now. > > Download your free book today! http://p.sf.net/sfu/neotech_d2d_may > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > The information contained in this message may be confidential and > proprietary to American Megatrends, Inc. This communication is > intended to be read only by the individual or entity to whom it is > addressed or by their designee. If the reader of this message is not > the intended recipient, you are on notice that any distribution of > this message, in any form, is strictly prohibited. Please promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and > then delete or destroy all copies of the transmission. > > ---------------------------------------------------------------------- > - > ------- > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft > technologies and advance your career. Get an incredible 1,500+ hours > of step-by-step tutorial videos with LearnDevNow. Subscribe today and > save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.c > l > ktrk > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel The information contained in this message may be confidential and proprietary to American Megatrends, Inc. This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
