On 05/26/15 14:35, B Cran wrote: > On Wed, May 13, 2015 at 11:01 AM, Peterson, Joe <joe.peter...@intel.com > <mailto:joe.peter...@intel.com>> wrote: > > Sorry for the delay in responding to this. With regard to involving > the community in a discussion of solutions, yes, there is no > intention of making this an "Intel only" thing. The posting of the > list shouldn't be seen as "this is what will be done," rather, this > is the list we have developed based upon feedback from the community > to date. If you have feedback or know of anything we missed, please > provide your feedback here via the mailing list. Also, we do not > intend to make this a home grown solution if we can avoid it. > > Please be encouraged to post questions/comment/concerns to the > mailing list. > > > I don't know how many others feel similarly, but I've seen very negative > feedback on Gerrit in the past at $work, mostly around its unfriendly > and ugly UI. If a code review system is going to be put into place, it > might make sense to use something that's more popular, in use by more > open source projects?
Nothing comes close to reviews done in email (*). As I stated earlier elsewhere: - No web based application will ever be as flexible as free flowing text for expressing thoughts about patches. I skimmed some upstream Gerrit page / examples before, and what I saw could certainly not accommodate the amount & format of text (eg. ASCII diagrams) that I sometimes produce. - Mailing lists are unbeaten at preserving threading, and at being archived / mirrored without coordination. (*) assuming (a) contributors use git-send-email to post patches, and (b) reviewers use sensible MUAs that don't mangle plaintext, monospace font emails. Gerrit may be okay for tight-knit internal teams, but for distributed development it's not appropriate in my opinion. Unless I'm wrong, Gerrit has been designed for in-house development, from the grounds up. I don't intend to use Gerrit, and I very much hope that all contributors will continue posting patches to, and accepting feedback from, the list. Thanks Laszlo > Also, are there any plans to open up the > tianocore.org <http://tianocore.org> site to other contributors, so > anyone (or at least active edk2-devel members) can contribute and edit > the pages? > > Bruce > > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel