On Jul 21, 2008, at 11:02 PM, David Reitter wrote: > On 19 Jul 2008, at 19:16, Adrian Robert wrote: >> >> It's been a longstanding TODO to normalize the cursor handling >> under NS. Both for storing the shape, as mentioned, and also the >> blink handling. Most of the code that's in there dates from before >> emacs itself had these features, and since it has been mostly >> working it's been less pain to keep it working than to rip it out >> and start afresh with the emacs stuff. Time for that to change, >> and I'd definitely welcome help or a patch for all or part of it. > > > The code below takes care of > > - frame background rather than the right glyph in the white-out > phases during blinking > - `cursor-type' variable as in core Emacs, rather than NS specific > solution > - with it, support for things like (box . 2) > - box/hollow cursors too narrow
Thanks, great stuff! But could you please summarize the changes? It shows like every line was changed (maybe because of indentation?) but it doesn't look like that was actually the case. Could you regenerate the patch w/o indentation/tab changes? > I don't understand why internal-show-cursor and the w->cursor_off_p > (that it sets) do not work in the NS port - they are checked by > redisplay_internal. Is there any commentary regarding stuff like > that? This is the way it is.. ;-/ Usually you just have to get your hands dirty and try to trace it back -- where does w->cursor_off_p get set, when/how are other terms calling or triggering functions that set it or trigger calling of draw_window_cursor(), etc.. > I mean, the original authors of this code went to lengths to replace > the blink-cursor-mode with something off their own (which is a lot > less configurable). As I said before, blinking cursor did not exist in core emacs when the NS port added this functionality. (Along with different cursor shapes.) Did you have any sort of a start on using the emacs common code (even though it didn't work)? Maybe if you post a patch for that others could take a stab at moving it further. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Emacs-app-dev- mailing list Emacs-app-dev-@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emacs-app-dev-
