Answers inline On Mon, 10 Nov 2025 at 19:30, Ihor Radchenko <[email protected]> wrote:
> Pedro Andres Aranda Gutierrez <[email protected]> writes: > > Now, continuing the code review. Let's move on to other files. > > > modified lisp/org.el > > > -(defun org-splice-latex-header (tpl def-pkg pkg snippets-p &optional > extra) > > +(defun org-splice-latex-header (tpl def-pkg pkg fspec snippets-p > &optional extra) > > This is a breaking change in the API function. Instead of adding a new > argument in the middle of the argument list, please add it as an > optional argument at the end. It will be the least intrusive approach. > This will be in an isolated commit. The rest is already committed. > > > (defcustom org-format-latex-header "\\documentclass{article} > > \\usepackage[usenames]{color} > > -\[DEFAULT-PACKAGES] > > -\[PACKAGES] > > Could you explain this change? > No, I've restored it.... > - ;; amsmath and amssymb after inputenc/fontenc for pdflatex > > + ;; amsmath and amssymb after inputenc/fontenc for pdflatex ?? > > Could you elaborate? > At one point, I was not sure whether we should not have this for other compilers too. I have spelt out the '??' as a FIXME > > modified lisp/ox-latex.el > > > +(declare-function org-list-or-null-p "org-macs.el" (object)) > > I think this is redundant. > I included this after my Emacs (with nativecomp) started complaining and it pacified it. > > -- > Ihor Radchenko // yantar92, > Org mode maintainer, > Learn more about Org mode at <https://orgmode.org/>. > Support Org development at <https://liberapay.com/org-mode>, > or support my work at <https://liberapay.com/yantar92> > -- Fragen sind nicht da, um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler "Sagen's Paradeiser" (ORF: Als Radiohören gefährlich war) => write BE! Year 1 of the New Koprocracy
