Morgan Smith <[email protected]> writes:

>> * <point>COMMENT TODO
>> M-x org-toggle-comment
>>
>> You will observe COMMENT stripped despite the heading not being
>> commented. In other words, there is a bug (or feature) in
>> org-toggle-comment.
>
> Strictly speaking, that heading is commented.  From worg org-syntax.org
> we have the heading format:
>
> #+begin_example
> STARS KEYWORD PRIORITY COMMENT TITLE TAGS
> #+end_example
> ...

You are right indeed.
However, I do not see then that what you observe in org-todo being a
feature. Simply a side effect of the internal implementation details.
You may call it a (minor) bug.

>> and, additionally, might introduce new bugs because the rest of the
>> org-todo code operates under assumption that the heading we work with is
>> not commented while todo is being changed.
>
> That is a valid concern.  I'll have to look into that.

This is the only remaining concern.
I recall that rewriting org-todo that I did no maintenance branch was
non-trivial and I left that comment/uncomment logic intact because it
was not clear what the consequences would be.

> Do you want to apply my first two patches while we figure out what to do
> about this third one?

Sure.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=8b9c9962a
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=13b241855

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to