Morgan Smith <[email protected]> writes: >> I recall that rewriting org-todo that I did no maintenance branch was >> non-trivial and I left that comment/uncomment logic intact because it >> was not clear what the consequences would be. > > This is a pretty core part of org-mode so it's understandable we both > have lots of fear, uncertainty, and doubt here. Let's shelf this for > now. I'll do more playing with testcover later to add test coverage for > the relevant code and we can revisit this then.
My thinking about these old functions is that rather than fixing edge cases in the old code, we should eventually re-design them using org-element API and more clear code style. That will be better than fixing one edge case just to make another popup as a result (that's what often happens with org-agenda fixes). I plan to do significant changes, including in org-todo, before Org 10 release. At least, when I get some free time after the initial surge of the bug reports resulting from the recent Org 9.8 release. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
