> That means that we can simplify > the process of creating a timer for an effort value if we follow the > following plan:
Would it make sense to move some of this logic to org-duration.el? If the format should be as specified in org-duration.el, then it makes sense this should be managed there. It seems the intent is for org-duration.el to serve as an API for dealing with durations generally which is another reason for using it. `org-duration-to-seconds' could implemented in org-duration.el. There's already `org-duration-to-minutes' there so it seems natural. The checking you describe could also be done there too, so org-timer could just pass the duration it gets (from effort estimates, point, minibuffer,...) as a string directly to `org-duration-to-seconds', which performs checks are returns seconds/nil/signals errors as appropriate. -- Paul
