Ihor Radchenko <[email protected]> writes: > "J.D. Smith" <[email protected]> writes: > >>> I am not sure if throwing an error is the best idea. >>> What if org-hide-emphasis-markers or org-link-descriptive change while >>> org-inside-mode is active? >> >> Switched to a simple message. > > I think we can slowly move to the code review.
Good. > Several code observations: > > 1. We need a section in the manual and some references to that section > from chapters related to emphasis Point me to the right section (unless someone more familiar with the manual prefers to take a crack). > 2. ORG-NEWS Ditto. > 3. There are currently no tests. Ideally, we want tests. Can someone else propose and implement simple test(s)? Not my forte. > 4. What will happen if org-link-descriptive or org-hide-emphasis-markers > are changed while org-inside-mode is active? Should be fine. The font-lock core will stop decorating them with cursor sensor. Toggle-hiding will notice there is no text marked invisible on the entity and do nothing. For now I just give a warning message if folks enable the mode without anything actually hidden.
