On Wed, Feb 6, 2013, at 06:25 AM, John Morris wrote:

> 
> Looking inside the old RT implementations, it is clear that one was
> written first, and following implementations simply copied
> <threads>_rtapi.c and <threads>_ulapi.c into new files and replaced the
> RT system-specific code, a small portion of the overall code.  A 'diff
> -u rtl_rtapi.c rtai_rtapi.c | diffstat' shows that 590 of ~1750 lines
> differ between the two rtapi implementations, and ~200 of ~840 lines in
> ulapi (the important differences are actually much smaller).

That is exactly how it happened (I was the guilty party).  It
bugged me a bit at the time, but not enough to make me
do it right.

> Benefits
> 
> It doesn't simply please my aesthetic senses to chop out 4k lines of
> duplicated code!  The resulting merged boilerplate and separated thread
> system-specific code naturally form a clean break that makes it easy to
> see what minimal code is needed to add a new RT system.  The RTAI code
> is only 275 lines, compared to about 1700 lines of more dense and
> daunting pre-cleanup code.

That is a huge improvement.

> If you've made it this far, I'm admirous of your high pain threshold and
> also grateful for taking the work seriously.  

I'm grateful to you for doing the work!

> 
>       John

-- 
  John Kasunich
  jmkasun...@fastmail.fm

------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers

Reply via email to