Curtis Dutton <curtd...@gmail.com> wrote:
>Ok I have integrated the wj200_vfd driver into linuxcnc >src/hal/user_comps/wj200_vfd > >The repository is available at https://github.com/OKComputers/linuxcnc Great, i'll review it later today. >During my work, I discovered a bug in the comp.py program. The problem >is >"option userinit yes" generates code that will not compile. > > Here is a link to the commit that has the fix.... I'll have to look closer at the bug later today. A request: it's helpful to reviewers if you put a good description of the problem you're fixing in the commit message. src/objects is not the right place for the bugfix, it should go in src/hal/utils/comp.g. src/objects is a temporary directory for files generated by the build system. Thanks for your work on this! -- Sebastian Kuzminsky ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
