On 05/14/2013 08:51 AM, Sebastian Kuzminsky wrote: > > > Curtis Dutton <curtd...@gmail.com> wrote: > >> Ok I have integrated the wj200_vfd driver into linuxcnc >> src/hal/user_comps/wj200_vfd >> >> The repository is available at https://github.com/OKComputers/linuxcnc > > Great, i'll review it later today.
Looks like you checked in wj200_vfd.c, which is a file that's the output of comp, was that intentional? Generated files should be generated by the build system from whatever their source is (a .comp file in this case), not checked into git directly. >> During my work, I discovered a bug in the comp.py program. The problem >> is >> "option userinit yes" generates code that will not compile. >> >> Here is a link to the commit that has the fix.... > > I'll have to look closer at the bug later today. A request: it's helpful to > reviewers if you put a good description of the problem you're fixing in the > commit message. > > src/objects is not the right place for the bugfix, it should go in > src/hal/utils/comp.g. src/objects is a temporary directory for files > generated by the build system. Your .comp doesn't use userinit, but there's definitely a comp bug there. Was this a bug you discovered during some testing that didn't make it into your branch? The only comp that sets 'option userinit yes' is bldc, but it doesnt set 'option userspace yes', so comp doesn't try to call it. Hmm, I'll update the comp docs to explicitly state that userinit only has an effect if userspace is set, and i'll update comp to fix the two syntax errors you found. Thanks for the bug report! -- Sebastian Kuzminsky ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
