On 11/21/2015 10:58 PM, Sebastian Kuzminsky wrote:
> On 11/21/2015 03:16 PM, Chris Radek wrote:
>> On Fri, Nov 06, 2015 at 10:48:17AM -0600, John Morris wrote:
>>>
>>> Thanks, Chris, for the initial (offline) review!
>>>
>>> Chris's suggestions are mostly (doc link problem fixed in main commit)
>>> incorporated in the top commit of [1], above. I'll squash them down for
>>> the final version, but left them separate for easier review.
>>
>> Hi John,
>>
>> I tried to add G52 to the quickref (docs/html/gcode.html) a while
>> back, only to find that lots/most of the links in there were broken
>> because of renames of some docs files. Now John T has fixed that
>> all up, and I rebased your branch on top of those fixes and added in
>> my quickref change again, and pushed it all as cradek/zultron/g52
>> for your consideration and for buildbot to chew on.
>>
>> I think Seb had a question about the new tests but I don't recall
>> what it was. Seb?
>
> I had a worry at one point about the g52 branch adding "*.var" to
> tests/.gitignore, but after taking a nap I feel better about it.
>
> I have no objections to merging g52 into master.
Thanks to the both of you for the reviews. I appreciate the concern
about `*.var` in `tests.gitignore`. If that's acceptable, please do
merge g52 into master!
John
------------------------------------------------------------------------------
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers
