Nice work, John! The only outstanding TODO's in my branch are these minor points:
- I added a few extra HAL pins to motion that may not be necessary (motion.spindle-tracking-gain, and motion.pos-tracking-mode) except for testing. - With spindle tracking gains of less than 1, the position error settles more slowly, which could indicate an algorithm issue. Otherwise, it should be ready to use On Thu, Feb 9, 2017 at 7:03 PM John Morris <j...@zultron.com> wrote: > On 01/27/2017 02:18 PM, sam sokolik wrote: > > quick testing - I don't get the error until I actually try to create a > > thread that is faster than the axis limit (for a given rpm) awesome! > > (and it doesn't seem to pause at the end when there is an error) > > This branch works for me, too. > > > On 01/26/2017 09:44 PM, Robert Ellenberg wrote: > >> For anyone interested in trying this out, I have fixes / improvements in > >> this branch now: > >> > >> - Less intrusive warning messages if the spindle is too fast > > I like this warning, "Reducing spindle speed from XXXX to YYYY for > synched motion," better than my warning-after-timeout proposal below: > it's simpler and it's sufficient to debug a hang on machines where > spindle speed is fixed. > > >> On Thu, Jan 26, 2017 at 3:10 AM John Morris <j...@zultron.com> wrote: > >> > >>> - Preview-time check: > >>> - Input: S value > >>> - Applicability: any machine > >>> - Fixed-speed spindles: operator must program S to benefit fm > check > >>> - Failure action: raise warning > >>> > >>> - Run-time check: > >>> - Input: spindle encoder output > >>> - Applicability: any machine with spindle encoder > >>> - No spindle encoder: hang waiting for index; see next > >>> - Failure action: scale spindle speed > >>> - After timeout on index/spindle-at-speed pins, raise warning > > I added the preview-time check onto Rob's branch, so IMO this work is > done. I updated the issue [1] for completeness. > > [1]: https://github.com/LinuxCNC/linuxcnc/issues/167 > > Thank you Rob for this fix, and thanks to everyone's contributions on > this thread. > > John > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > _______________________________________________ > Emc-developers mailing list > Emc-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/emc-developers > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
