Rob, It looks like Phill beat me to it. Thanks for taking this up for us.
Chris, it seems there needs to be a process to look at new work becasue what you are saying is if you are not in the inner sanctum, you can't contribute. But if you are in the inner sanctum, you don't have the time. Certainly a Catch22 and its users like us who suffer if guys like Randy and Phill aren't given the keys to the inner sanctum. But it begs the question if Tormach paid for the development and depended it for their business, why wasn't their work merged when it was all fresh and you had them on side to guide the process through if it broke something? I think state tags has some nice features that would make Phills job as the plasma machine expert a lot easier (like reading the Commanded velocity as the current velocity is not useful in the plasma context). Hopefully we can move forward from here. Rod Webster *1300 896 832* +61 435 765 611 Vehicle Modifications Network www.vehiclemods.net.au On Wed, 22 May 2019 at 09:39, Phillip Carter <[email protected]> wrote: > Rob, > > The branch I have working is here > https://github.com/phillc54/linuxcnc/tree/reverse-run < > https://github.com/phillc54/linuxcnc/tree/reverse-run> it was up to date > with master yesterday. > > Basically what I did was add your original reverse run commits to an up to > date master (12 Dec 2018) one at a time and then made changes until they > took and appeared to work. There were a couple of commits that I couldn’t > get to take but from memory they where some sort of tidy up and not > necessary. There was also an additional commit I did at the end for a > ramping acceleration issue. I thought I kept a list of notes of what I did > but I seemed to have misplaced it, I will keep searching. It would be great > if you could go through it to see if it is ok. > > Cheers, Phill. > > > On 22 May 2019, at 9:19 am, Chris Morley <[email protected]> > wrote: > > > > > > > > ________________________________ > > From: Rod Webster <[email protected]> > > Sent: May 21, 2019 10:43 PM > > To: EMC developers > > Subject: Re: [Emc-developers] Introduction and a couple of questions > > > > Chris/Rob/Andy > > > >>> I don't want to sound negative or a whinger. > > You don't - it's frustration > > > >>>> Reverse run is not even in master yet - so how could we release it? > > > >>> So the question really is why did Phill have to start again? All he > did was > >>> update that branch. It should have been in master by now. > >>> Why don't you at least get his work into the official repository? > > > > There is no process for merging work. It usually comes down to the guy > who made the > > code merging it himself. The guy who made this was not a dev and none of > the devs > > needed it. > > compounded that master is used so regularly that devs are reluctant to > commit work that is not theirs, in case > > it breaks things. - Who will fix it in a timely matter. > > > > As you can see alot of catch 22s here. > > > >> The last commit to the state tags branch was in February 2015 and I > >> understand its been in use commercially since around then. > >> What causes this paralysis? > > > > Pilotpath is it's own project they pay people to work on the code for > what they want. > > Again with no formal merge process nor enough devs to spend on it the > patches sit too long, then are hard to merge. > > > >> Why did I see Andy's multi spindle sneak into master and I knew nothing > >> about it? Yeh, I know I don't use a spindle but I do follow progress > pretty > >> closely > >> You might recall that was not entirely bug free on its debut. > > > > Andy can push his own work and commit to fixing what broke quickly. > > There was no serious talk of release in the near future. > > > >> I think what Phill has done with his plasma component and GU's is > amazing. > >> But he > >> should not need to maintain the core code for a 4 year old feature on a > >> private repository to achieve it. > > > > I agree - and it's great they we are talking about it - I feel this time > something will happen. > > > > We have tried a few time to address these short comings and have never > got it satisfactory. > > But the project continues. > > > > Chris M > > > > _______________________________________________ > > Emc-developers mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/emc-developers > > > _______________________________________________ > Emc-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/emc-developers > _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
