Thanks for the link. I have a fix for issue #30. I left a comment there. Bob
-----Original Message----- From: Chris Morley [mailto:chrisinnana...@hotmail.com] Sent: Saturday, October 09, 2021 12:48 PM To: EMC developers Subject: Re: [Emc-developers] G10 rotations Issue are tracked here: https://github.com/LinuxCNC/linuxcnc/issues [https://opengraph.githubassets.com/f576eff123ce33a5f8c206b59f76d7d9e644c9ae 4e94fa2fccf967dfd1a1ad47/LinuxCNC/linuxcnc]<https://github.com/LinuxCNC/linu xcnc/issues> Issues . LinuxCNC/linuxcnc . GitHub<https://github.com/LinuxCNC/linuxcnc/issues> LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more. - Issues . LinuxCNC/linuxcnc github.com ________________________________ From: Bob Bond <r.b...@frontier.com> Sent: October 9, 2021 5:25 PM To: 'EMC developers' <emc-developers@lists.sourceforge.net> Subject: Re: [Emc-developers] G10 rotations I've found a couple of problems so far, mostly related to G92 offsets in rotated systems. How can I check for bug reports and issues in this area? Thanks, Bob -----Original Message----- From: Bob Bond [mailto:r.b...@frontier.com] Sent: Thursday, October 07, 2021 10:20 AM To: emc-developers@lists.sourceforge.net Subject: [Emc-developers] G10 rotations I've been reviewing the interpreter code in some detail with respect to xy rotations specified via G10 R parameters. I think there may be a few problems. The code in some cases appears to assume that the results of an translation followed by a rotation about the translated Z axis is the same as a rotation about the current Z axis followed by a translation. In other cases the (g28, g30) the code doesn't take the rotations into account. The purpose of this note is to tie down the semantics. Here's what I think they are, using the G5x code as a "gold standard". 1) Tool x, y offsets are relative to the machine coordinate system. 2) G10 xy rotations should be around the G5x translated axis. Ie, first you translate then you rotate. 3) G92, G52 offsets are relative to the current G5x coordinate system To make this a bit more concrete, here's how G28.1 convert_savehome() should work when it reduces current_x, current_y to an absolute point: 1) Add the G92 offset 2) Unrotate 3) Add the G5x offset 4) Add the tool offset Comments please. I'm deep enough into this now that I can probably come up with a set of proposed patches for people to play with. There are dragons out there though given that persistent parameters (g28 saved positions, for example) may be interpreted differently after the changes. Bob Bond _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
