I can't find tests/interp/5440... I see a reference to it in the discussion in issue but the test seems to be gone now.
Bob -----Original Message----- From: Bob Bond [mailto:[email protected]] Sent: Sunday, October 10, 2021 7:30 PM To: 'EMC developers' Subject: Re: [Emc-developers] G10 rotations Hi Chris, Thanks for the note. I posted the pull request this afternoon. It has two new tests, one for the G53 bug and one for G28. I would love to have you review the PR! I'll check out this test. Bob -----Original Message----- From: Chris Radek [mailto:[email protected]] Sent: Sunday, October 10, 2021 6:43 PM To: EMC developers Subject: Re: [Emc-developers] G10 rotations Hi Bob, This is wonderful, thank you for working on this after almost 6 years! Did you see that there's a test, tests/interp/5440 that is partly disabled because of this bug? When you build your pull request it would be great if it included a commit that reenables this test fully, confirming your changes. You might also want to add to the test to show other ways you've confirmed your changes, if appropriate. If you don't see how to do that I'd be happy to help. https://github.com/LinuxCNC/linuxcnc/commit/896baee1ffee202 Cheers, Chris _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
