Rainer,

Attached is my proposed changes to G74 and G84 in the docs.

Please let me know if you think anything about it should be changed.

I did think of adding the R- and L- explanations to G81 too.  But I am
trying to refrain from going too far down the docs editing rabbit hole.
Let me know if you'd like me to add that as well before I PR.

Thanks,

Greg

On Mon, Oct 18, 2021 at 7:00 AM Rainer Stelzer <r.stel...@sgs-robotics.de>
wrote:

> Hi Greg,
>
> > Although, I do wonder if no X or Y are given, should L still be valid?
>
> totally agree.
>
> I retrofitted some machines with Sinumerik 810 controls.
> Tapping and rigid tapping are done with the same G code on this controls
> but ask for different  parameters.
> In combination with a very "economic" way of telling the user about the
> detailed error,
> you often find yourself in a stopped state and you have no clue whats
> wrong.
>
> Linuxcnc should through an error if  L  is used in absolute mode with
> G84, or without an X or Y Axis  (like e.g. G53 does if it is not).
>
> I made some extensions to the homing procedures, and had some issues
> with M19 and G33.1 ,
> so I'm working/reviewing the source anyhow right now.
> I will have a look into to the  G84 implementation and figure out how
> hard it is to add this warning.
>
> Cheers
>
> Rainer
>
>
>
> _______________________________________________
> Emc-developers mailing list
> Emc-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/emc-developers
>
diff --git a/docs/src/gcode/g-code.txt b/docs/src/gcode/g-code.txt
index 23576110b..7d3469493 100755
--- a/docs/src/gcode/g-code.txt
+++ b/docs/src/gcode/g-code.txt
@@ -1637,9 +1637,17 @@ It is an error if:
 (((G74 Left-hand Tapping Cycle Dwell)))
 
 ----
-G74 (X- Y- Z-) or (U- V- W-) R- L- P- $-
+G74 (X- Y- Z-) or (U- V- W-) R- L- P- $- F-
 ----
 
+* 'R-' - Retract position along the Z axis.
+* 'L-' - Used in incremental mode; number of times to repeat the cycle. See <<gcode:g81,G81>> for examples.
+* 'P-' - Dwell time (seconds).
+* '$-' - Selected spindle.
+* 'F-' - Feed rate (spindle speed multiplied by distance traveled per revolution (thread pitch)).
+
+WARNING: G74 does not use synchronized motion.
+
 The 'G74' cycle is intended for tapping with floating chuck and dwell at the bottom of the hole.
 
     1. Preliminary motion, as described in the
@@ -1659,8 +1667,8 @@ The 'G74' cycle is intended for tapping with floating chuck and dwell at the bot
 
     8. Restore Feed and Speed override enables to previous state
 
-The length of the dwell is specified by a 'P-' word in the G74 block. Thread pitch is F divided by S.
-In example S100 F125 gives pitch of 1.25MM per revolution.
+The length of the dwell is specified by a 'P-' word in the G74 block. The feed rate 'F-' is spindle speed multiplied by distance per revolution (thread pitch).
+In example S100 with 1.25MM per revolution thread pitch gives a feed of F125.
 
 [[gcode:g76]]
 == G76 Threading Cycle
@@ -2240,9 +2248,17 @@ It is an error if:
 (((G84 Right-hand Tapping Cycle Dwell)))
 
 ----
-G84 (X- Y- Z-) or (U- V- W-) R- L- P- $-
+G84 (X- Y- Z-) or (U- V- W-) R- L- P- $- F-
 ----
 
+* 'R-' - Retract position along the Z axis.
+* 'L-' - Used in incremental mode; number of times to repeat the cycle. See <<gcode:g81,G81>> for examples.
+* 'P-' - Dwell time (seconds).
+* '$-' - Selected spindle.
+* 'F-' - Feed rate (spindle speed multiplied by distance traveled per revolution (thread pitch)).
+
+WARNING: G84 does not use synchronized motion.
+
 The 'G84' cycle is intended for tapping with floating chuck and dwell at the bottom of the hole.
 
     1. Preliminary motion, as described in the
@@ -2262,8 +2278,8 @@ The 'G84' cycle is intended for tapping with floating chuck and dwell at the bot
 
     8. Restore Feed and Speed override enables to previous state
 
-The length of the dwell is specified by a 'P-' word in the G84 block. Thread pitch is F divided by S.
-In example S100 F125 gives pitch of 1.25MM per revolution.
+The length of the dwell is specified by a 'P-' word in the G84 block. The feed rate 'F-' is spindle speed multiplied by distance per revolution (thread pitch).
+In example S100 with 1.25MM per revolution thread pitch gives a feed of F125.
 
 [[gcode:g85]]
 == G85 Boring Cycle, Feed Out
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers

Reply via email to