Moti Asayag has posted comments on this change.
Change subject: core: support optional reboot after Host installation completes
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
a minor comment regarding parameter naming
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/InstallVdsParameters.java
Line 55: public boolean isReboot() {
it is just a matter of taste but shouldReboot/isRebootNeeded sounds more
natural.
--
To view, visit http://gerrit.ovirt.org/2124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47ff2e10b9425ff492a79315fb3d7587969b0125
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
