Roy Golan has posted comments on this change. Change subject: core: support optional reboot after Host installation completes ......................................................................
Patch Set 3: (2 inline comments) .................................................... File backend/manager/conf/vds_installer.py Line 246: execfn += str(int(rebootAfterInstallation)) I get your point. so in order to stay consistant I would add a patch to refactor all execfn += to append in that context Line 350: opts, args = getopt.getopt(sys.argv[1:], "bc:m:r:O:t:n:u:p:f:") unfortunately the getopts api expects boolean values not to be the last so I have 2 options, either leave it like that or "c:m:r:O:t:n:u:p:bf:" -- To view, visit http://gerrit.ovirt.org/2124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47ff2e10b9425ff492a79315fb3d7587969b0125 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
