Doron Fediuck has posted comments on this change.
Change subject: core: support optional reboot after Host installation completes
......................................................................
Patch Set 3: (4 inline comments)
Roy,
You did some very nice things there,
and some still need to be handled.
See inline.
....................................................
File backend/manager/conf/vds_installer.py
Line 246: execfn += str(int(rebootAfterInstallation))
Roy,
Please use append here:
execfn.append(str(int(rebootAfterInstallation)))
Line 350: opts, args = getopt.getopt(sys.argv[1:],
"bc:m:r:O:t:n:u:p:f:")
You need to be more consistent;
if you always add the reboot flag at the end, the same should apply here
(and make sure not to skip the 2 dots):
"c:m:r:O:t:n:u:p:f:b:"
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 82: T parameters = getParameters();
Good job!
Line 136: || isOvirtReInstallOrUpgrade()) {
Very nice optimization!!!
--
To view, visit http://gerrit.ovirt.org/2124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47ff2e10b9425ff492a79315fb3d7587969b0125
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
