Mark Wu has posted comments on this change. Change subject: Add more detailed memory statistics function to guest agent. ......................................................................
Patch Set 2: Gal, Thanks for your review. If we put the message of getMemoryStats into 'heartbeat' as you suggested, then we needn't call sendMemoryStats periodically in the main loop. And getAvailableRAM is not needed, because getMemoryStats already contains that information. Definitely, we need change vdsm guest agent code accordingly. If we keep getMemoryStats as a separate command, it could have its own interval value. It seems more flexible if the stats collecting work gets heavy for guest. In normal case, it shouldn't be a problem for guest. Which idea do you like more? In addition, "^M" appeared at the end of the changed lines in my patch. I am not sure if it can be applied. It seems the original files in repo was written on Windows host. Is it fine for you if I post the patch converted by dos2unix to your personal email? Thanks! -- To view, visit http://gerrit.ovirt.org/2272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic93b8717f99f033caf2b5dc2404a55f903bf4b0a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
