Adam Litke has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comment)
Looks good except for one long line in OVirtAgentLogic.py.
....................................................
File ovirt-guest-agent/OVirtAgentLogic.py
Line 93: self.vio.write('heartbeat', { 'free-ram' :
self.dr.getAvailableRAM(), 'memory-stat': self.dr.getMemoryStats()})
This is a pretty long line. Try to break it up into two. We try to avoid
lines that are longer than 80 characters.
--
To view, visit http://gerrit.ovirt.org/2272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93b8717f99f033caf2b5dc2404a55f903bf4b0a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
