Barak Azulay has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
see internal comments
....................................................
File ovirt-guest-agent/GuestAgentLinux2.py
Line 177: ret = {'swap_in' : 0, 'swap_out' : 0, 'pageflt' : 0, 'majflt'
: 0}
Since this dictionary is being used by both linux & windows, it needs to be
defined at the DataRetriverBase class.
Line 182:
white spaces above
....................................................
File ovirt-guest-agent/OVirtAgentLogic.py
Line 154: self.sendMemoryStats()
The above call is not required when this info appears in the heartbeat
--
To view, visit http://gerrit.ovirt.org/2272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93b8717f99f033caf2b5dc2404a55f903bf4b0a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
