Oved Ourfali has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes ......................................................................
Patch Set 3: (2 inline comments) minor comments .................................................... File backend/manager/dbscripts/gluster_volumes_sp.sql Line 9: Please remove the trailing whitespaces from this file. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeStatus.java Line 17: Consider using UP/Down status, to make it more consistent with statuses we already have today (it also makes sense as the volume can be stopped, and started). Not a major comment, more like a PM issue, as we already have up/down for vms, active/inactive for storage domains, and now you'll add online/offline as well :-) -- To view, visit http://gerrit.ovirt.org/2936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I820af17b8c9c7f0414f67bd03364ce3e14d6f178 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
