Shireesh Anjal has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes ......................................................................
Patch Set 4: Following changes done as per review comments: - removed trailing whitespace from gluster_volumes_sp.sql - renamed GlusterVolumeDao to GlusterVolumeDAO - changed volume and brick status enum names from ONLINE/OFFLINE to UP/DOWN - Added javadoc comments to method getGlusterVolumeDao in DBFacade - Started storing enums as varchar instead of INTEGER in DB -- To view, visit http://gerrit.ovirt.org/2936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I820af17b8c9c7f0414f67bd03364ce3e14d6f178 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
