Yair Zaslavsky has posted comments on this change.
Change subject: engine: DB scripts, entities and DAO for Gluster Volumes
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/03_01_0670_add_gluster_volume_tables.sql
Line 6: if (not exists (select 1 from INFORMATION_SCHEMA.TABLES where
table_name='gluster_volumes')) then
Correct.
My mistake.
But - as mentioned before, I see no reason for perfoming this, the way our
upgrade script works.
It's not that critical though, you can keep as it is.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeStatus.java
Line 18: public int getValue() {
I think it will be more useful for debugging.
You're correct in your observation - I was referring you to a new Status and
entity (Snapshot & SnapshotStatus) on purpose.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
Line 760:
Just a matter of coding style.
--
To view, visit http://gerrit.ovirt.org/2936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I820af17b8c9c7f0414f67bd03364ce3e14d6f178
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
