Gal Hammer has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File ovirt-guest-agent/GuestAgentWin32.py
Line 335: colItems = objSWbemServices.ExecQuery("SELECT * FROM
Win32_PerfFormattedData_PerfOS_Memory")
Did you test it when the agent is running as a Windows service?
I once tried (and failed) to use WMI when running the agent as a service. If
your method is working then I have learned something new :-).
....................................................
File ovirt-guest-agent/OVirtAgentLogic.py
Line 187: self.vio.write('memory-stats', { 'memory' :
self.dr.getMemoryStats() })
Is this function is in use?
--
To view, visit http://gerrit.ovirt.org/2272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93b8717f99f033caf2b5dc2404a55f903bf4b0a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
