Federico Simoncelli has posted comments on this change.
Change subject: backend,frontend: add more specific glance errors
......................................................................
Patch Set 1:
(2 comments)
> 1. We usually add messages to 3 AppError.properties files
Yes I saw that, and I wondered why. Several messages are not in all 3.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java
Line 200: }
Line 201: }
Line 202:
Line 203: if (diskImage == null) {
Line 204: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_NOT_EXIST);
Technically it could if we don't handle all the error types (that might be
added in the future) in the switch statement. I felt safer leaving this here
but I can remove it if you want.
Line 205: }
Line 206:
Line 207: return true;
Line 208: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageException.java
Line 13:
Line 14: public OpenStackImageException(ErrorType errorType) {
Line 15: this.errorType = errorType;
Line 16: }
Line 17:
Ah right I was in the "library" mindset, I tried to mimic what RuntimeException
does. Yes if we look at what I use here, these would be useless at the moment.
Line 18: public OpenStackImageException(ErrorType errorType, String
message) {
Line 19: super(message);
Line 20: this.errorType = errorType;
Line 21: }
--
To view, visit http://gerrit.ovirt.org/19370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecba90adfc2be50fb1471ac93908fde176696404
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
