Sergey Gotliv has posted comments on this change.
Change subject: backend,frontend: add more specific glance errors
......................................................................
Patch Set 1:
(2 comments)
I assume based on its location in sources that this one is used for REST API:
backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Two others are used in webadmin and userportal according to their locations.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java
Line 187:
Line 188: try {
Line 189: diskImage = getDiskImage();
Line 190: } catch (OpenStackImageException e) {
Line 191: log.errorFormat("Unable to get the disk image from the
provider proxy: {0}", e.getMessage());
I have no problem with e.getMessage() in this case (CDA, we can understand what
happen later by VdcBllMessage), but since message is not always exists (you
created constructor without message) maybe sometimes you need to print stack
trace.
Line 192: switch (e.getErrorType()) {
Line 193: case UNSUPPORTED_CONTAINER_FORMAT:
Line 194: case UNSUPPORTED_DISK_FORMAT:
Line 195: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_IMAGE_NOT_SUPPORTED);
Line 200: }
Line 201: }
Line 202:
Line 203: if (diskImage == null) {
Line 204: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_NOT_EXIST);
I think move it to 'default" area in the switch will be better.
But don't change it if you don't have to provide additional patch because of
property files.
Line 205: }
Line 206:
Line 207: return true;
Line 208: }
--
To view, visit http://gerrit.ovirt.org/19370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecba90adfc2be50fb1471ac93908fde176696404
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
