Allon Mureinik has posted comments on this change.
Change subject: backend,frontend: add more specific glance errors
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Basically looks OK, some minor nits inline - please fix 'em when you apply
Cheryn's suggestions.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageException.java
Line 8: UNABLE_TO_DOWNLOAD_IMAGE,
Line 9: UNRECOGNIZED_IMAGE_FORMAT
Line 10: }
Line 11:
Line 12: ErrorType errorType;
this should be private
Line 13:
Line 14: public OpenStackImageException(ErrorType errorType) {
Line 15: this.errorType = errorType;
Line 16: }
Line 10: }
Line 11:
Line 12: ErrorType errorType;
Line 13:
Line 14: public OpenStackImageException(ErrorType errorType) {
AFAIK, this ctor isn't used in this patch - I'd just remove it.
Line 15: this.errorType = errorType;
Line 16: }
Line 17:
Line 18: public OpenStackImageException(ErrorType errorType, String
message) {
--
To view, visit http://gerrit.ovirt.org/19370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecba90adfc2be50fb1471ac93908fde176696404
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
