Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: partial cleanup - db only
......................................................................
Patch Set 7:
(2 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/core.py
Line 65: osetupcons.CoreEnv.LEGACY_PG_CREDS_FOUND
Line 66: ] and
Line 67: self.environment[
Line 68: osetupcons.RPMDistroEnv.VERSIONLOCK_MODIFIED
Line 69: ]
relaying on the version lock modification is quite dangerous... as admin could
have removed it. as it legacy only, I can live with that... but in future
please try to avoid.
Line 70: )
Line 71:
Line 72:
....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py
Line 98: raise RuntimeError(
Line 99: _('Unexpected empty database during upgrade')
Line 100: )
Line 101: else:
Line 102: raise RuntimeError(
please move this up and remove the nesting.
if !found:
raise ...
try to connect
Line 103: _(
Line 104: 'Could not find database access credentials in
legacy'
Line 105: 'pgpass file {pgpass}'
Line 106: ).format(
--
To view, visit http://gerrit.ovirt.org/19689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
