Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: partial cleanup - db only
......................................................................
Patch Set 7:
(2 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/core.py
Line 65: osetupcons.CoreEnv.LEGACY_PG_CREDS_FOUND
Line 66: ] and
Line 67: self.environment[
Line 68: osetupcons.RPMDistroEnv.VERSIONLOCK_MODIFIED
Line 69: ]
I agree it's dangerous. But I also think it's not very good (and probably
dangerous) to wrongly identify the state of the system - that's why I added all
the reasonable conditions I thought about, most of them discussed elsewhere in
the past. We can remove it if you want. Perhaps the rest are safe enough...
Do note that legacy pgpass is not deleted on upgrade without this change. It's
only deleted by 3.2 cleanup. This means that 3.3.0 users that upgraded from 3.2
have it. I am glad I managed to convince you to rename back
/etc/sysconfig/ovirt-engine on closeup. Sadly, we don't have something very
reliable to know precisely what our state is, and even if we had, of course the
admin could have changed that too.
Line 70: )
Line 71:
Line 72:
....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py
Line 98: raise RuntimeError(
Line 99: _('Unexpected empty database during upgrade')
Line 100: )
Line 101: else:
Line 102: raise RuntimeError(
Actually, on a second thought, this is not needed. If ! LEGACY_PG_CREDS_FOUND,
also ! UPGRADE_FROM_LEGACY, so we won't run this function. Reverting.
Line 103: _(
Line 104: 'Could not find database access credentials in
legacy'
Line 105: 'pgpass file {pgpass}'
Line 106: ).format(
--
To view, visit http://gerrit.ovirt.org/19689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
