Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: partial cleanup - db only ......................................................................
Patch Set 9: Code-Review+1 OK... the only think I do not like here is that the legacy logic leaks out of the legacy plugin (versionlock). Had I do this, I would have just 'greped' the versionlock in the legacy plugin to know if it contains the packages, and constraint the legacy within its own plugin without noise, so in next version we can just remove it without implications. -- To view, visit http://gerrit.ovirt.org/19689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
