Gilad Chaplik has posted comments on this change.

Change subject: webadmin: user portal and webadmin localization
......................................................................


Patch Set 7:

- I can agree on the enums (because of the search), others no, we can pass 
along with the event/alert/task whatever text, a key indicating it's id, and 
have a shared file with backend. in localization, we simply override it in the 
ui.
- I suggest that the check style plugin be optional (once a week we can auto 
run it or sth), unless we'll have the eclipse smart plugin (again like android 
for eclipse)

--
To view, visit http://gerrit.ovirt.org/3612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74c56a3aed35dec0a378efc58a2e44569eff6089
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to