Alona Kaplan has posted comments on this change. Change subject: webadmin: user portal and webadmin localization ......................................................................
Patch Set 9: * Regarding patch separation: how difficult is it? - It is not difficult but it will take time. I prefer not to do it... * Regarding Eclipse/mvn plug-in - There is a build in option in eclipse to mark (throw compile error) non-externalized strings. preferences=>java=>compiler=>errors/warning=>non-externalized strings (missing/unused $NON-NLS$ tag) => error - There is also another option- you can add to the eclipse a checkstyle-plugin (help=>marketplace=>checkstyle) and make our checkstyle.xml file to be the default eclipse checkstyle (like explained here- http://eclipse-cs.sourceforge.net/basic_setup_project.html). I will cause all checksyle errors to be marked in the eclipse configuration. -- To view, visit http://gerrit.ovirt.org/3612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74c56a3aed35dec0a378efc58a2e44569eff6089 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
