Einav Cohen has posted comments on this change. Change subject: webadmin: user portal and webadmin localization ......................................................................
Patch Set 9: - Regarding patch separation: Not critical; only if really easy and trivial; not worth doing an artificial, difficult separation work just for the sake of separation. Alona - how difficult is it? - Regarding Eclipse/mvn plug-in: I didn't understand in the end if an Eclipse plug-in can be used or not. If there is, there should be problem that the check-style mvn plug-in will fail compilation on hard-coded strings in the GUI code. Alona - Do we have an Eclipse plug in? Can we use it? - Regarding localizing events/alerts/tasks: As already mentioned earlier, engine-core work needs to be done in order to support this appropriately. This can be handled later, no need to do it as part of this patch (which is a pure GUI patch). If there are other open issues - please share. -- To view, visit http://gerrit.ovirt.org/3612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74c56a3aed35dec0a378efc58a2e44569eff6089 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
