Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fix problems in engine-backup.sh
......................................................................
Patch Set 5:
(1 comment)
bug is yours, so it is local discussion anyway.
I don't care what user should do/check, I do not want that automation will
result in unexpected behavior.
A simple message that service should be started will do the trick as well.
Also you break platform independent with this code.
You can detect if engine is running by checking ${ENGINE_UP_MARK} fetching pid
and see if exists.
....................................................
File packaging/bin/engine-backup.sh
Line 188: || logdie "Database backup failed"
Line 189: }
Line 190:
Line 191: dorestore() {
Line 192: service ovirt-engine status > /dev/null 2>&1 && \
this is bad and will not work in systemd (near future) or any other
distribution.
Line 193: logdie "Engine service is active - can not restore
backup"
Line 194: output "Restoring..."
Line 195: log "Opening tarball ${FILE} to ${TEMP_FOLDER}"
Line 196: tar -C "${TEMP_FOLDER}" -pSsxf "${FILE}" || logdie "cannot open
${TEMP_FOLDER}"
--
To view, visit http://gerrit.ovirt.org/20264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I464e795627af23712696212e4589e4b8480bb8a0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
