Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fix problems in engine-backup.sh
......................................................................
Patch Set 4:
(4 comments)
....................................................
File packaging/bin/engine-backup.sh
Line 55: all complete backup/restore (default)
Line 56: db database only
Line 57: --file=FILE file to use during backup or restore
Line 58: --log=FILE log file to use
Line 59: --do-not-start-services do not start services
no... opt in not opt out for dangerous zone.
Line 60: __EOF__
Line 61: return 0
Line 62: }
Line 63:
Line 211: log "Verifying connection"
Line 212: verifyConnection
Line 213: log "Restoring database backup at
${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 214: restoreDB "${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 215: if [ "${START_SERVICES}" = 1 ]; then
no need for parameter like this, as admin should be able to know what to
restart either by message at end of script or services that are marked to be
started at boot.
Line 216: #TODO: Do this at all?
Line 217: output "Starting services:"
Line 218: service ovirt-engine start || die "Failed to start
engine service"
Line 219: service httpd restart || logdie "Failed to restart
httpd"
Line 214: restoreDB "${TEMP_FOLDER}/db/${DB_BACKUP_FILE_NAME}"
Line 215: if [ "${START_SERVICES}" = 1 ]; then
Line 216: #TODO: Do this at all?
Line 217: output "Starting services:"
Line 218: service ovirt-engine start || die "Failed to start
engine service"
a message of: please start ovirt-engine service when ready should be sufficient.
Line 219: service httpd restart || logdie "Failed to restart
httpd"
Line 220: fi
Line 221: output "Note: you might need to manually fix:"
Line 222: output "- iptables/firewalld configuration"
Line 215: if [ "${START_SERVICES}" = 1 ]; then
Line 216: #TODO: Do this at all?
Line 217: output "Starting services:"
Line 218: service ovirt-engine start || die "Failed to start
engine service"
Line 219: service httpd restart || logdie "Failed to restart
httpd"
httpd restart is none intrusive restart, we can do this always.
Line 220: fi
Line 221: output "Note: you might need to manually fix:"
Line 222: output "- iptables/firewalld configuration"
Line 223: output "- autostart of ovirt-engine service"
--
To view, visit http://gerrit.ovirt.org/20264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I464e795627af23712696212e4589e4b8480bb8a0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
